Code Review 🦊 SO MUCH LEARNING #6 Building an Online Business

Подписаться 351 тыс.

Просмотров 30 тыс.

50% 1

Sponsored by: FullStack Javascript Developer Edegree on Kickstarter by Eduonix www.kickstarte...
Explaining our project to MPJ to get feedback on the code. Basically we get him started up on his computer - which takes AGES. 😅 Then we fix things from the last episode!
00:46 Setting MPJ up 🛠
14:28 Code Review BRIEF
17:29 Code Review FIXING IT UP
34:25 Retrospective 🏁 - What did we learn??
#codereview #pairprogramming #nextjs #reactjs
Last episode when David built the things we fix here
▶️ • Adding a Database to N...
This episodes code on Github
💻 github.com/chh...
Learn Next.js with their own super great free tutorial/course
🖖 nextjs.org/learn/
The editor is called Visual Studio Code and is free. Look for the Live Share extension to share your environment with friends
💻 code.visualstu...
DevTips is a weekly show for YOU who want to be inspired 👍 and learn 🖖 about programming. Hosted by David and MPJ - two notorious bug generators 💖 and teachers 🤗. Exploring code together and learning programming along the way - yay!
Fun Fun Function is the sister channel of DevTips
❤️ / funfunfunction

Опубликовано:

28 сен 2024

Ссылка:

Скачать:

Готовим ссылку...

Добавить в:

Мой плейлист

Посмотреть позже

Комментарии : 69

@mtheoryx83 6 лет назад

I think a great part of this is the extra effort at the end to do a retrospective. So many times people (including myself) do a thing, then just move right onto the next thing. Taking some time for reflection is how improvements happen, and you two showed how it can be done very respectfully. We can all learn a great deal from that.

@JonPreece 6 лет назад

You guys really need to install, and use, prettier. You're always manually formatting your code. I've been using Prettier for some time now and its so cool I never have to worry about formatting my code ever again

@DanKaschel 2 года назад

I don't like formatting tools. They fight me when we disagree on how something should look.

@Ahmad-ww4ue 2 года назад

prettier is a life saver.

@martinnyagah4313 6 лет назад

I was confused at first when you guys came in but I decided to wait and see how it goes. Honestly, I am glad I did not leave. I speak for myself but I love how you are doing this in the real world kinda way. Making mistakes, and finding solutions plus giving very valuable advice that most might take for granted. Like test driven development or testing out your code before or after is a very valuable trait. I am honestly committed to the channel and what you two are doing. I love the background music by the way, very relaxing and weirdly triggers my thinking..Good job you two.

@sebastianhewelt2197 6 лет назад

This is e x a c t l y why I like you guys too!

@BrianDriesenga 6 лет назад

Learning tons! Thanks for talking this all through....good to have a deeper understanding.

@t3rman1 6 лет назад

Another fun tutorial :) You can map the docs property of snapshot. I could see that was annoying mpj :) This line should do it. return snapshot.docs.map( doc => ({id: doc.id,...doc.data() }) )

@RobertBMenke 6 лет назад

Pair programming > code review. Well said.

@cristianrosescu2914 6 лет назад

I think I have a better understanding of await and promises and when await can/not be used. An episode with examples on when to use or not to use async/await would be great.

@OfficialDevTips 6 лет назад

Check out this episode (and comments) on Fun Fun Function: ru-vid.com/video/%D0%B2%D0%B8%D0%B4%D0%B5%D0%BE-ho5PnBOoacw.html

@Hasel32CH 6 лет назад

MPJ you win the award for coolest shirt! 😀

@peterthefoxx 5 лет назад

Hey nice series, really helped me progress with nextjs however I've encountered a security issue with the database setup used and it's probably worth people knowing that they shouldn't use this in a real application. Nextjs shares everything with the client, all your env values will be visible on the client side! - You can see this in chrome dev tools if you search for one of your ENV variable names from the sources tab then you see it's publicly visible. Not sure of a fix yet other than having to make a separate api that nextjs can talk to.

@Joshca4 6 лет назад

i like this kind of videos, more of this please!

@AbhishekKumar-mq1tt 6 лет назад

Thank u for this awesome video and series

@t3rman1 6 лет назад

Good luck with your new business :)

@sholomaber 6 лет назад

During the retrospective you mentioned how pair programming is superior to code review. Does that mean code review is not required if the code was written in the pair programming method?

@OfficialDevTips 6 лет назад

Correct. It becomes reviewed as it is being done. Also it removes a lot of downtime for someone to get up to speed with the code. All in all it can be more effective then one doing coding, and someone else later having to figure out intent and correcting bugs.

@robertbrogers3 6 лет назад

I'm confused as to how the getInitialProps is used. It's returning a promise as well with the .then returning an object. Does the calling code use async and await to use the values 'returned' from the promise?

@mellet89 6 лет назад

When the "page component" is run on server side in next js, it will call the getInitialProps function on your component first. Wait for the result(doesnt matter if the calling code is using then or await, it's just a implementation detail) of the function and inject it as a prop to the component before returning the response to the web browser :) If you want to dive down deep you can check out the source code of the App(root componet) of nextjs and what it does here: github.com/zeit/next.js/blob/canary/lib/app.js

@robertbrogers3 6 лет назад

thanks

@sdelvalle57 6 лет назад

How about hosting it on firebase?

@mellet89 6 лет назад

You can check out this example to see how to host a nextjs app on firebase: github.com/zeit/next.js/tree/canary/examples/with-firebase-hosting

@krishnaidamakanti1644 6 лет назад

Thank you.. myfavs.in

@AdityaFingerstyle 5 лет назад

33:44 I found it really shocking that MPJ didn't know what a static function was. Great video though 👌

@SuprunAlexey 6 лет назад

Interesting

@spotted756 6 лет назад

Could you explain why 404 does not throw an error when using Promises but it does when you use async await? repl.it/@Deviad/Maybe-Data-structure Thank you. Anyways, the one in the video is a typical situation when Typescript and Flow can save you lots of time.

@davidluhr 6 лет назад

Really enjoying the learning content of the series. It may be helpful to provide an overall plan of what you are working on and planning for the future. For example, right now, is there a specific MVP you are working towards, or are you still exploring and learning potential technologies to use? At what point are you going to define the business in terms of it's services and revenue, or begin designing what the website will look and do? Starting each episode with a quick recap of what you're trying to accomplish at this stage would be really useful. Thanks for putting these videos together!

@max-mr5xf 6 лет назад

On *NIX and OSX console.error doesn't only print red but uses stderr instead of stdout. So error messages can be handled seperately, also redirected, while being displayed in your terminal by default.

@DanKaschel 2 года назад

Windows as well.

@t3rman1 6 лет назад

The whole thing. return loadFirebase() .firestore() .collection('agencies') .limit(10) .get() .then( (snapshot) => { return snapshot.docs.map( doc => ({id: doc.id,...doc.data() }) ) });

@mrmagicrapattack 6 лет назад

Go map that snapshot! stackoverflow.com/questions/46614055/map-items-of-collection-snapshot-in-firebase-firestore

@richie-bonilla 6 лет назад

Great episode. I love that the edit is not polished to the point of being sterilized. Watching how you reason about things or use a bit of tooling is very helpful. It helps me, as a self-taught dev, know that the way I do certain in-between things is not inefficient/unusual.

@vamseetelugupriest 4 года назад

Code vs agile manifesto must be compared.

@wilhelm.reeves 4 года назад

You guys are so fun 💜 Love your channel 👍 ✌ ✨

@JuhoLehtinenLehtuska 5 лет назад

I think you could use querySnapshot.docs.map

@douglosu 6 лет назад

As someone who has been in the industry a long time, this code review was so representative of what it is really like in a lot of places, even the beginning part, it almost gave me code review PTSD.

@FurbnMax 3 года назад

haha well said

@UniBreakfast 5 лет назад

Music is too loud I would say.(

@gamberril 4 года назад

Very interesting !

@DarkZoneGamingMain 5 лет назад

Absolutely fantastic episode. You guys should keep making these long kids where you code together, it really helps us learn how people work together and engineers figuring stuff out and also very nice to watch besides the learning. Thanks so much for this you guys rock

@ksuhavoloshuk2644 5 лет назад

Thanks for this episode, it was really helpful to understand more the code review process in practice. Our team is using Review Assistant since it integrates with Visual Studio, and it suits us fine. But could you please recommend some plugins for code formatting?

@samwemyss5002 6 лет назад

First video I have fully watched since David and MPJ took over. And to be honest it was actually quite informative if not a little slow / roundabout (nothing 2x speed can't fix). I really liked the comment from MPJ on speculative code and how that isn't very useful for the team/yourself later on. Keep it up! Keen to see you guys improve and learn from different perspectives

@spotted756 6 лет назад

Hello, I would have created a promise that returns null or undefiend and used setTimeout to simulate a delay for example in order to test that catch thing.

@iRedee 6 лет назад

Would love to see more of this code review concept. But suggest there be more comment should be written when writing the code in the first place. Both help to code review and so that people can follow along easier...

@BirkirRGujonsson 6 лет назад

Instead of the forEach you could simply return a map, removing the result array, push etc.

@ericellison2413 6 лет назад

2:38 => Read/write so that you can destroy my system ...... mpj is the jimmy kimmel of coding ..... love that dude ...

@mojar2680 6 лет назад

You are not growing inside the devtips channel, you guys are great. But you should create your own fanbase / yt channel for actual exposure

@thearchibaldtuttle 6 лет назад

I have no idea what you are doing but the life share feature is awesome!

@puyanwei 6 лет назад

Nice relaxing music... sometimes coding is not that relaxing lol :D

@sreekumarmenon 6 лет назад

fyi, "next start" is to be run after running . "next build"

@slimhmidi6398 6 лет назад

Very very interesting episode

@TheSldsnake 6 лет назад

Amazing episode pls more !!

@rafaklimek6527 6 лет назад

that's magic for me xd

@emberchord 6 лет назад

they are so handsome :o

@rexli2017 6 лет назад

Huge support

@sivuyilemagutywa5286 6 лет назад

thank you

@anandpande5425 6 лет назад

Online business from scratch 🤔

@OfficialDevTips 6 лет назад

We should have a poll. At which episode will there be a functioning website? (... #50?) At which episode do we have some sort of revenue? 😅

@anandpande5425 6 лет назад

DevTips The final episode have to be in between #20 to #25 (for some kind of revenue) ..... otherwise it becomes lengthy 🙃

@QWEEKEN73 6 лет назад

Great insight. I am working on a meal prep app (keyword working). I have the functionality pretty much finished for the front-end. From the user's side, it lets you pin point what person you'd like to order meals from, requests info on what meals they are offering (currently static JSON), and then renders the items as product cards on the screen for you to then choose and purchase. This is my first full-fledged project. If you get a chance, could you please take a look and see if I'm heading in the right direction. - github.com/SenseiCain/meal-prep-app Thank you!