Early Refactoring in C# - A TimCo Retail Manager Video 

I'm not an EF expert (I barely use it) so you could be right. Would this have renamed the database? If so, wouldn't we want to make the change before this point, though, since it will still have the old name in the migration path?

You are welcome.

You are welcome.

We are glad you are enjoying it.

Thanks!

Hi Harag, my UI to this course is actually a Xamarin forms, using UWP. Caliburn micro and the rest third party toolS that Tim used wouldnt work with Xamarin forms as it is .NETCore and caliburn micro is created for .NETFramwork. I Suggest u use FreshMVVM for Xamarin forms to get DI, singleton and all, it works pretty good.

Thanks for sharing.

Thanks :D

I will add it to the list. Thanks for the suggestion.

Thanks for sharing that tip.

Don't let the video fool you - I don't always figure it out that quickly. I'm not sure I even figured it out this time that fast. Sometimes I pause the video, think, and then restart the video. Debugging is about experience. The more you do it, the more scenarios you will have encountered. So, the better a person is at debugging, the more things they have screwed up in the past. Great job figuring it out.

You are welcome.

You are welcome.

The multibinding would work but it doesn't allow us to be as granular about the formatting of each item.

I understand. I figure that the two letters add a bit of clarity and that is worth it to me. It doesn't hurt anything and it makes things a bit clearer.

Good question but no, we still need to add the container to itself.

I'll think about it. I'm not sure that the added complexities are warranted based upon the potential gain, but I'll think it through more. Thanks for the suggestion.

That would be an issue since recreating it won't create the same IDs for the same people. That will cause all of your existing records to be orphaned.

Sounds good.

@@IAmTimCorey Meanwhile I know why that happened: XAML uses the us-engl Culture per default, instead of the ToString function, which uses the preset of the local computer ...

@CoderboyPB You can change this in your XAML. Add "xmlns:gl="clr-namespace:System.Globalization;assembly=mscorlib" to the settings of the XAML. Now bind the Text property of the TextBlock etc like this : Text="{Binding Taxes, StringFormat={}{0:c2}, ConverterCulture={x:Static gl:CultureInfo.CurrentCulture}}" Thus way XAML will use the Culture of your operating system

@@sergestevens6034 thank you!

I know I'm a couple of months late to your comment, but you can also set the property Language="de-DE" on your shell window (or on each individual View control) in order to force a specific locale. This is necessary because WPF out of the box doesn't take the system locale into account for things like currency formats. If you don't want to hard-code it this way, I'm sure this property could also be data-bound to some property in the ShellViewModel. That way you could read it in from a settings file or something. Oh, and if you want the € sign displayed in front of the number, you can use "de-AT" instead. Because apparently for some obscure reason, this format is different for Austria than it is for Germany, even though both versions should be correct for both countries. But for consistency's sake it probably would be best to set the WPF controls to the same culture setting as the rest of your application, which will default to your system's settings unless specified otherwise.

We don't need to test the IoC method itself but we did make it somewhat harder to unit test our class now, since the dependency comes from IoC. We will need to mock the IoC directly in order to replace that dependency. Otherwise, it should be fine.

It is a habit of mine to keep an old database around for a bit to be sure I didn't have any other important data in it before I got rid of it. In this case, though, I can delete the database at any time.

@@IAmTimCorey makes sense. I'd suggest to rename it though -> something-obsolete... (Saves me from having to play the guessing game again later)

Naming is one of personal preference in these cases. I'm not a big fan of those names but if they work for you, great. As for Package Manager, I've explained where that comes from a few times before but I'll try to remember to explain it next time. As for the migration, I had some type of bug in the system but I showed a workaround for it, which I'm fine with. It prevented showing a long, drawn-out debugging session. As for renaming the database, that's not a great option because that won't always be an option. If you don't have a database, that doesn't work. I'll add the content controls suggestion to the list for possible future improvements.

To 5: You can set TextElement.FontSize="14" on the first stack panel. All strings in the stack panel will inherit the value. I think they call it attached property, like Grid.Row or Grid.Column.

Thanks for sharing!

Thanks for sharing!

You get it from the Entity Framework-created authentication database in the Users table.

It is on the suggestion list. Thanks!

It sounds like maybe you have a database issue but I'm not sure. Try debugging the application and capturing the error before it comes back as a 500 (which doesn't tell you much). See what that error tells you.

We had to get multiple instances of the Login form so we couldn't reuse the same instance we get from the constructor.

@@IAmTimCorey Ah! That's right. Thanks for the quick reply and the great content!

My guess is that your .gitignore file does not have the same entries that mine does.

@@IAmTimCorey That's what's odd, my git ignore file has some minor differences to yours. None that I can explain why I had the refactor log and you didn't. From what I read it seems as if you should have had the refactor log as it's used to track database changes. I hate a mystery, but this is one I will have to live with at least for now. Thanks

I'm not sure I see the difference.

@@IAmTimCorey I think the difference would come if you had an interface for the container

You can fix this, just break it into small steps. If you use version control, back out the refactoring and start over. Either way, break it into small changes and test after each. You got this!

The reason is that after recreating the user in the new EFData database, the new User Id doesn't match the User Id in the existing TRMData Database. It is also fixed later in the video.

Yep, just cosmetic and IoC is cleaner.

A tip - Embrace GIT for version control + make changes with confidence. Later, (if the need arises) you can debug by reviewing the delta and (worst case) undo changes that caused you grief.

Nope, I didn't need to escalate the VS privileges. As for the item price, I think that has to do with the formatting of the box. I believe someone else fixed that here but I can't remember the exact fix.

@@IAmTimCorey thanks for the information. Silly me...found it in the comments. Must have read over it. Thanks.

I find that unit testing is a valuable tool (that I want to get into this project but I purposefully waited to do) but I am not fully sold on TDD.

IAmTimCorey Robert Martin once compared unit testing to double-entry bookkeeping. In my opinion writing tests after the fact is dangerous. One might simply forget it once the production code seems to be complete. To me it feels like waiting for adding the second entry in bookkeeping until the end of the week. Every good bookkeeper would laugh at that idea. In the same way a good developer should regard writing production code and unit tests as an atomic process. TDD enforces this. Also it makes you think about your production code from the perspective of a consumer of that code right from the beginning. I would like to hear your thoughts on why you are not fully sold on TDD.

Good feedback on the database name. I should have chosen something a bit clearer. For me, I only use EF for authentication but I should have called it AuthDB, not EFData. Maybe I'll adjust that in a future video. As for the LINQ speed issue, good point. I try to highlight different ways of doing things but I should also mention the speed issue. My guess is that because I did two extension methods instead of doing one "full" LINQ statement that it was slower. I'll have to look into it.

@@IAmTimCorey Also for the database name, wouldn't it be good if the name would make clear to which application it belongs, e.g. by calling it "TRM_AuthDB"?

@@IAmTimCorey I have not looked into it either but the predicate clause has to have a build up and tear down. I expect that to be the case.

@@99MrX99 IMHO no. Real world applications normally end up using a central store (Active Directory) or an SSO (single sign-on) using OAuth or SAML (becoming obsolete) so why rename it at all for a dev project.

I don't have an example of that, sorry.

@@IAmTimCorey thanks, figured it out. Thinking about adding it to TimCo app so it can do EDI.

Interesting. Thanks for sharing.

Caching the userId and passing it along with the ID would be a security risk. If I was authenticated as Tim and got the ID of 1 back, I could just pass in 2 instead (with my valid token) and now all of my actions in the database would be logged as Jane instead of Tim. The token is the only thing you can depend on from the client. You must use that to identify the user each time. You can't trust the user to do the right thing. That means that every single call would need to look up the ID to then use it in any transaction. That will be more expensive than storing a GUID as the primary key for the user.

@@IAmTimCorey I meant you could use the gud/nvarchar(128) to get a cached user object that would contain the integer key. I do not see any security risk as now you are using the key directly so using the key to look up a server cached value would decrease security. I did not want the request to also include a separate id, that would be redundant, less secure and not a good practice I agree.

WebAPI is a stateless connection. That means that you can't cache the ID between calls. The only effective way to cache it would be on the client side, which I discussed is not safe. So, your only other option is to do the lookup each time a call is made.

​@@IAmTimCorey Based on the key there is nothing to prevent the server running the webapi from caching in either a session state, database or external cache (redis) a session cache might not be usefull for scarsely used api's.

Maybe you are not passing in the type during authentication or maybe you are calling a GET instead of a POST.

@Victor, I had this same issue, ensure that your app is launching the browser. if not check that you have both started: DesktopUI and TRMDataManager. Right click Solution > Properties, check Startup Project for these to be set to Start.

Hi @@IAmTimCorey , I am actually calling a POST method. During debug the password returns an empty string(I thought it should be a hashed value)?, and my fiddler wouldnt even pick up the webApi call. I followed this tutorial religiously, to now lose track like smh.

@@onyebuchiboss 1. Ensure that on startup BOTH ui and manager project run as @Dame F said. 2. Ensure that the user id in the TRMData database user table is the same as the one in EFData database AspNetUsers table.

It always fails in APIHelper autheniticate it gets in proper username and password and IsSuccessStatusCode is false

anyone? i can post entire github repo here but i think the data is the problem and i just don't even know where to start

well unless i start from scratch but that's a lot of work and @IAmTimCorey told us multiple times not to delete and start from scratch

You cannot roll back the data in a database, no. You will need to fix it manually. My guess, though, is that you could fix it by modifying the actual data directly in SQL rather than trying to start over. Use SSMS to modify the data manually to fix it.

@@IAmTimCorey Thank you so much , i'll try using SSMS , i tried manualy to fix it only trough visual studio so far , but the longer i think about it the longer it seem that i copied the wrong id , so i might at least go trough quite a lot , but i'll do my best , if i use swagger(and possibly postman) to create another entry and all the following steps would that possibly fix it because that's what i'm doing right now