When You Ask the Intern to Review Your Code 

And then never getting merged until it is inevitably closed!

Bro!! I thought I was the only one. I had fixed a major issue in production, gave the PR and it got merged after two months lol. I had literally zero tasks for those months

The best python package of my life was never even reviewed

This gave me PTSD

Months? More like years! I have in all seriousness a couple of PR's from over a year(when I started) open. Lets see if they are gonna be reviewed next year...

There are some words in that hudge fact

As a frontend dev who started just 6 months ago i need to say that this comment made me calm 😁 Thanks

Omg is this what I get to look forward to?

True! The best is when seniors just explain everything without me having to ask😂😂😭

Fun and brilliant! But maybe also a way to say that rather than having a fourth internship one should be hired or at least get a consultancy? Don't know about the specific situation so maybe you'll tell more, but fourth internship (and at the same company!) sounds out of this world to me

​@@matteosposato9448 i had a friend who did 4 separate terms at a big fintech company and he worked on a different team each time

@@matteosposato9448probably still in school so they were waiting to hire him

​@@matteosposato9448I've seen that for students that are going into Master's program

Lmao chuckled so hard 😂😂😂

Actually, "colour" is 20% less efficient than "color", but "color" is 16,67% more effective than "colour"

You can actually put 10% of the code in the filename. Huge space saver.

😂😂😂😂

Please don’t use the name of God in vain!

glad you enjoyed it

​@@nicholastwhat is the name of that utility at the start of the video where you are managing all the tasks, looks cool?

@@adityasuryawanshi3263 "Trello" I'm assuming

That's an every software developer experience, including for seniors.

Has happened so many times to me...

Classic

Naaah you legit gotta do that 😂😂😂😂😂😂. The smarter it sounds the more impressed the HR's are. It's legit comedy sometimes

congrats on internship!

so are you intern manager yet?

chief intern officer

That's a CIO... 😂 not CEO

Chief Executive Intern

That doesn't sound like a "senior" dev, but what do we juniors know lmao, maybe he was into something

Been there, that’s real life. Maybe not at FAANG, but in smaller companies or teams this can definitely happen. Promotions based on seniority, not skill level… My advice: Stay away from those companies/teams. Work with skilled people and for companies that value skill.

​@@Haise-sanhe probably was on to something he didn't become a senior engineer just like that. right guys ?

At least he zipped it. He could have sent a rider into your town to read the code out loud in the market square.

HOW HOW HOW HOW HOW DID THAT HAPPEN ????? My last interview I straight up outperformed 90% of the candidates and that was still not good enough. WHAT THE FUCK ????

I work on legacy mainly, and it's a lot of "do exactly what was requested, and _only_ what was requested". Just today I got back from lunch to find several messages about how a PR of mine last week broke the release branch for everyone on another (parallel) team. This issue could be solved with a basic try-catch, but to be honest having looked through it further I don't know that we want to even make the change I was asked to make (and already implemented, albeit with a bug) due to subtle issues that are direct results of this plan.

You need someone to help you with prioritizing the tasks, taking stakeholder impact into account

​@@traveller23eThis was nice to read. Sometimes I'm scared that I'm the only idiot that makes these kinda breaking changes.

Im working as an intern in an ML research project, mostly just reporting results from different papers. I feel like ive hit a ceiling mathematically and my major isnt focused on ML its actually cybersecurity. How do you suggest I get better?

@@rewrose2838 Nah mate, people have broken release three times since I wrote that a week ago. As long as someone catches it before there's a real problem, you're fine.

CI is the bare minimum. Most part of code review isn't even about things that broke. Also really depends on the quality of CI how reliable it is for detecting broken things.

@@andyschee942 Big vouch for the Scheester. Making sure that your code follows the proper standards (well documented with comments, proper usage of variables and functions, ensuring everything is clean etc.) is super integral to having great code. Bad code breaks, good code just works, great code works and can be understood and fixed easily in the future.

Bum

Gigachad

Keep it like that. Work sucks.

​@@SkyArmysGenerallife's tough and unpredictable. Be humble.

It's that and also everyone has a Senior who just rubberstamps everything for their best friend that is filled with breaking changes, yet everytime they review your PR they go through it character by character nitpicking every detail with comments.

Glad you enjoyed it :)

MORE SKITS COMING

LFFGG

Knowing when and how to ask questions is knowledge too

I don't mind nitpicking, it's all in how they conduct it. If they ask the right questions, like "Would it be better if we do XYZ? or "Are we able to do such and such on this line?" than they give you the opportunity to rebuttal or agree without them feeling like an ass, and you feeling like an idiot. Most good companies train on how to properly review PR's, and its a Senior priority to keep comments professional.

My rule of thumb is that if you're not learning much, maybe it's time to switch jobs.

you can apply directly to cs

Trello kanban board